As I look at the photo uploader I see it is importing the BxDolFilesUploader.php so I assumed that is what is generating the photo uploader form. I change the require => true to require => false and I don't see a red asterisk beside the description box on the photo upload form but when I try to submit the form the bozo checker yells that the description can not be left blank. By the way, the photo is uploaded and stored anyway, if a person simply leaves the form they will find the photo in the album and without a description. If I am changing the required state for the description the correct way, evidently the bozo checker does not see this change. Where is the bozo checker for photos uploader? Geeks, making the world a better place |
BxPhotoUpload.prototype.doValidateFileInfo = function(oButtonDom, iFileID) { var bRes = true; if ($('#send_file_info_' + iFileID + ' input[name=title]').val()=='') { $('#send_file_info_' + iFileID + ' input[name=title]').parent().parent().children('.warn').show().attr('float_info', _t('_bx_photos_val_title_err')); bRes = false; } else $('#send_file_info_' + iFileID + ' input[name=title]').parent().parent().children('.warn').hide(); if ($('#send_file_info_' + iFileID + ' textarea[name=description]').val()=='') { $('#send_file_info_' + iFileID + ' textarea[name=description]').parent().parent().children('.warn').show().attr('float_info', _t('_bx_photos_val_descr_err')); bRes = false; } else $('#send_file_info_' + iFileID + ' textarea[name=description]').parent().parent().children('.warn').hide(); return bRes; //can submit }
OK, who are the javascript folks here?
Geeks, making the world a better place |
if ($('#send_file_info_' + iFileID + ' textarea[name=description]').val()=='') { $('#send_file_info_' + iFileID + ' textarea[name=description]').parent().parent().children('.warn').show().attr('float_info', _t('_bx_photos_val_descr_err')); bRes = false; }
I am guessing we are checking here to see if the description is null. If so, then we return an error and we put the ! in a red circle.
Geeks, making the world a better place |
Will this work?
BxPhotoUpload.prototype.doValidateFileInfo = function(oButtonDom, iFileID) { var bRes = true; if ($('#send_file_info_' + iFileID + ' input[name=title]').val()=='') { $('#send_file_info_' + iFileID + ' input[name=title]').parent().parent().children('.warn').show().attr('float_info', _t('_bx_photos_val_title_err')); bRes = false; } else $('#send_file_info_' + iFileID + ' input[name=title]').parent().parent().children('.warn').hide();
$('#send_file_info_' + iFileID + ' textarea[name=description]').parent().parent().children('.warn').hide(); return bRes; //can submit }
Geeks, making the world a better place |
No it won't but this will.
BxPhotoUpload.prototype.doValidateFileInfo = function(oButtonDom, iFileID) { var bRes = true; if ($('#send_file_info_' + iFileID + ' input[name=title]').val()=='') { $('#send_file_info_' + iFileID + ' input[name=title]').parent().parent().children('.warn').show().attr('float_info', _t('_bx_photos_val_title_err')); bRes = false; } else $('#send_file_info_' + iFileID + ' input[name=title]').parent().parent().children('.warn').hide(); return bRes; //can submit }
Geeks, making the world a better place |
Maybe in Dolphin 8 we can just check some switches in the admin to decide if we want descriptions mandatory or not. Geeks, making the world a better place |
Now, where is the autofill for the description box? I have never liked it autofilling the title in the description; better as some say to just leave it blank and not make it mandatory. Geeks, making the world a better place |
By the way, in the photo view page, the edit pop-up still has description mandatory; so that will eventually need to be fixed as well. Anyone want to jump in and help with that part of the equation? Geeks, making the world a better place |