Please turn warnings on an fix all warnings

Dolphin is a complex system.  Developing without warnings on is like trying to fix something with half the lights off.  For version  7.1, could you please change

error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED);

to

error_reporting(E_ALL & ~E_DEPRECATED);

Personally, I'd like it to be E_ALL (or E_ALL | E_STRICT), and have all deprecated functions removed as well.  Do we really need to be setting magic_quotes in 2011?

There aren't that many places where warnings come up.  I'd be happy to do these simple changes, if given SVN access.  In fact, I'd be thrilled to do so.  I'm working on module development right now, and warnings are enormously helpful.

I've been making changes to my code, to fix the warnings in the core so I can see the problems in my modules.  The problem is that these are no on my local machine only, not on my other developer's machine.

Here's an example of one:

Notice: Undefined variable: sModule in C:\usr\sites\dolphin\flash\modules\global\inc\header.inc.php on line 26


A quick fix would be something like:

if(!defined("MODULE_DB_PREFIX"))

define("MODULE_DB_PREFIX", DB_PREFIX . ucfirst(empty($sModule) ? '' : $sModule));

But probably a better fix would be to see what $sModule isn't set here.
The other warnings are mostly initialization errors: $skin, 'logged_in' index (Notice: Undefined index: logged in C:\usr\sites\dolphin\inc\profiles.inc.php on line 44)
and $lang.
Thanks for your consideration in fixing these, or allowing me to do so.  I promise you that allowing developers to see warnings will make for better coding!!!!
Tac
Quote · 7 Jan 2011
 
 
Below is the legacy version of the Boonex site, maintained for Dolphin.Pro 7.x support.
The new Dolphin solution is powered by UNA Community Management System.