This may have already been addressed but searching was returning a lot of hits that were not related; not sure if this is a 7.1.1 bug that has been fixed or related to the Rayz Video Embed module I am using.
After I upgraded our site to 7.1.1 a member reported that she could not embed videos into her video album. I confirmed the problem existed and moved to checking the files changes for Rayz's module in case I overlooked one in the upgrade process and upgraded to the latest version of the module. However, I am unsure of where the issue lies. What I have determined is that for one to embed a video, they must manually move focus from the URL input field before clicking on the submit button; clicking the submit multiple times does not result in the embedding. You have to click out of the URL input field so that field loses focus before clicking the submit button.
Edit: Is there a way I can check bug reports in each version? I am slowing trying to get the site upgraded to 7.1.4 but need to work out issues since my site is heavily modified.
Geeks, making the world a better place |
That happens with the embed module. The person has to click out of the embed link box before they click submit. |
That happens with the embed module. The person has to click out of the embed link box before they click submit.
This only started after I upgraded to 7.1.1. If this is an issue with the embed module has it been reported?
Geeks, making the world a better place |
OK, I understand the nature of the issue; when you past in the URL, it is not seeing the input field as changing, therefore the submit button is not active. However, that is exactly what users are going to be doing, pasting in the URL because one copies the URL from the video hosting site. Therefore, a solution other than telling members to click someone else on the page is needed. Geeks, making the world a better place |
When I look at this in the inspect with firebug I see:
<input class="form_input_text bx-def-font" type="text" name="embed" onkeyup="parent.oVideoUpload.rzCheckEmbed()" onchange="parent.oVideoUpload.rzCheckEmbed()" onclick="parent.oVideoUpload.rzCheckEmbed()"
value="http://youtu.be/aQ24ykIBVOM">
So it would appear that the value has been assigned; I should be able to click continue and embed the video without clicking somewhere else on the page.
Geeks, making the world a better place |
OK, I have played with this some more and the keypress check is working, If you paste in with the keyboard then you can click on submit and the video will be added. The checks are:
onkeyup="parent.oVideoUpload.rzCheckEmbed()"
onchange="parent.oVideoUpload.rzCheckEmbed()"
onclick="parent.oVideoUpload.rzCheckEmbed()"
If you paste in using the mouse; on PC, click in input field, right click mouse, click on paste, then the check is not working. Clicking with the mouse on paste should have triggered the last check in the list above. However, it does not. I have only checked this with FireFox, since browsers handle javascript, it may work in other browses and then again it may not.
Geeks, making the world a better place |
I put a simple alert into the javascript function so I could track what happens when using the mouse to paste in the URL. When you click into the field, the click is detected and the function runs. However, right clicking and selecting paste from the right-click menu is not detected.
javascript does not have handlers that can detect context menu clicks.
Geeks, making the world a better place |
onchange fires when the input loses focus. However, there is oninput. oninput is not supported in IE <=8.
Occurs when the text content of an element is changed through the user interface.
Geeks, making the world a better place |
https://www.deanbassett.com |
Thanks Dean, if someone had told me this at the beginning; someone told me that it is the way it is, I could have saved me some time.
|
|
function shVideoEnableSubmit(bMode) { |
|
|
if(this.getType() == 'embed') |
|
|
if($('#video_upload_form').attr("name") == 'embed') |
|
|
return; |
Basically they remove the check if the type is embed. Now I have Rayz video embed module that removes the change for his module. Why I would have to ask Rayz.
However, I may can get by with the oninput handler and keep Rayz's change in place. However, I can not find where they add the handlers to the input form, I have search the code, can not find a template; are they using javascript to add in the handlers? Deano, if you can tell me that, I may just add in the oninput and call it a day. I will ask Rayz about his change.
Geeks, making the world a better place |
I just purchased Rayz video embed a few days ago (sound and photo embed too). Running on 7.1.4. When I paste a video url in and click submit, sometimes nothing happens. If I hit the enter button on my keyboard then it works. Or click around the page first and then click submit. Now I know why. Frustrating.
Also running into the problem that youtube video embeds do not show the duration caption. All videos show 00:00 time in thumbnails, but that's a separate problem I have no idea how to fix, and it seems neither does Rayz.
|
I just purchased Rayz video embed a few days ago (sound and photo embed too). Running on 7.1.4. When I paste a video url in and click submit, sometimes nothing happens. If I hit the enter button on my keyboard then it works. Or click around the page first and then click submit. Now I know why. Frustrating.
Also running into the problem that youtube video embeds do not show the duration caption. All videos show 00:00 time in thumbnails, but that's a separate problem I have no idea how to fix, and it seems neither does Rayz.
Mentioned it to Rayz and he replied. We will see what can be done about the mouse paste of the URL.
Geeks, making the world a better place |
Thanks Dean, if someone had told me this at the beginning; someone told me that it is the way it is, I could have saved me some time.
I would have but I don't troll as much as I used to.
ManOfTeal.COM a Proud UNA site, six years running strong! |
I just purchased Rayz video embed a few days ago (sound and photo embed too). Running on 7.1.4. When I paste a video url in and click submit, sometimes nothing happens.
I too own the embed feature from Rayz and don't have any problems with that, nor Youtube's.
ManOfTeal.COM a Proud UNA site, six years running strong! |
Rayz had made a change in his code, I put back the changes that Dolphin made to upload.js and made a small change in Rayz's module.
@Newton, I believe you have a different version from the one I have. This is the vbrowser module with the added embed sources.
Geeks, making the world a better place |
I just purchased Rayz video embed a few days ago (sound and photo embed too). Running on 7.1.4. When I paste a video url in and click submit, sometimes nothing happens. If I hit the enter button on my keyboard then it works. Or click around the page first and then click submit. Now I know why. Frustrating.
Also running into the problem that youtube video embeds do not show the duration caption. All videos show 00:00 time in thumbnails, but that's a separate problem I have no idea how to fix, and it seems neither does Rayz.
Rayz provided a fix for the vbrowser module I use, contact him about your problem; he has several versions of his advance embed. For me, the module is: http://www.boonex.com/m/embed-videos, and has the directory name under Rayz as vbrowser.
Geeks, making the world a better place |
I will contact him. I have Advanced Video Embed 3.0. |
Rayz has asked me to share his fix on this forum topic.
Undo the commenting out of the code in upload.js in the Boonex Video module as requested in the installation instructions of Rayz's module.
Then in Rayz's module:
edit "modules/rayz/embed/classes/RzEmbedModule.php" file, find the following code:
'disabled' => 'disabled'
and remove it, so the code should stay like:
'submit' => array( 'type' => 'submit', 'name' => 'shoot', 'value' => _t('_Continue'), 'colspan' => true, 'attrs' => array( 'onclick'=>"return parent." . $sJsPostObject . "._loading(true); shVideoEnableSubmit(false);" ), ),
In the case of the module I have, the file is actually /rayz/vbrowser/classes/RzVbrowserModule.php
Geeks, making the world a better place |
Rayz just sent me the fix. Similar as you posted.
For Embed 3.0, didn't need to touch the upload.js file, just delete or comment out 'disabled' => 'disabled'.
Worked like a charm.
|