[7.1.4] Update function not working?

At the moment i try to find out how the Dolphin automatic module updater is working. Did everything as described in Wiki article http://www.boonex.com/trac/dolphin/wiki/HowToMakeAutomaticUpgradeScriptForModule

But if i try to download the update in modules section per Admin Panel i just get the message "Wrong package format"

I doublechecked everything and all seems to be ok, anyone out there having an idea whats wrong??

Thanks in advance!!

Ok, i was able to fix that problem, it seems to be a bug in BxDolInstallerUi.php

On line 461 you will find

$sConfigPath = $sTmpPath . $sPackageRootFolder . '/install/config.php';

that needs to be

$sConfigPath = $sTmpPath . $sPackageRootFolder . '/config.php';

since ZipArchives "getNameIndex" function is not returning the toplevel directory name but the first entry inside the zip archive.

This dirty fix is not not a good thing because if the first entry is not the "install" folder this will result in error.

So i think there must be an other way determining the toplevel directory ... any ideas??

The first entry in the zip file is not suppose to be the install folder.

Did you package your zip file properly?

The install folder is suppose to be inside another folder like update_100_101  (update_fromver_tover)

yes that is correct ... i zipped the file accordingly to the guidline ... see the screenshot, i am packing the folder "update_265_266"

dont know where this problem comes from but it seems that the "getNameIndex" function just returns files and not folders ...

i think it would be safer to do something like this in BxDolInstallerUi class.

                $sPackageRootFolderTmp = $oZip->numFiles > 0 ? $oZip->getNameIndex(0) : false;
                $aPackageRootFolderTmp = explode("/", $sPackageRootFolderTmp);
                $sPackageRootFolder = $aPackageRootFolderTmp[0];

What do you think?

Unknown.

I could never get the regular installer working in any of the past versions. So i gave up on it years ago. Which is why most developers provide manual upload instructions.

I have not checked out the new version. Just making sure you have it packed per the requirement.

I will not be supporting it for a while anyway. I pack to support multiple versions of dolphin, and until boonex fixes the market to allow multiple versions of main packages as well so people can download a proper package for the version of dolphin they are using, then i will not support it. I will not abandon the older versions of dolphin just for this. I don't think very many vendors will.

Ok, thanks Deano for your input ...

AlexT, what do you think??

And the customers appreciate this stance.  I doubt if Boonex is going to devote much time to developing a better backend module installer when there are many other areas they are ignoring that are more important.

Module installer and updater is very important in my opinion ...

Hello

As I see files structure looks correctly, but are you sure you correctly archived the package which is available to downlod?

Did you check the result of dearchiving in tmp folder of your Dolphin script?

P. S. I tried to create a test module with test update script and it worked for me.

Yes, did check everything and it looks good over here. Also the dearchived files are all ok.

Have no clue why this happens, anyway ... today i got another problem with the updater, it tells me

"-- Check module hash: Module was modified" !?!?

Aaaahhhhh, got it ... it checks for changes on the module files before updating *niceomat*